BVTCK-57 Avoid the use of @BeforeMethod

jakartaee / validation-tck

Jakarta Validation TCK

http://validator.hibernate.org

Apache License 2.0

38 stars 33 forks source link

BVTCK-57 Avoid the use of @BeforeMethod #86

Closed marko-bekhta closed 7 years ago

marko-bekhta commented 7 years ago

https://hibernate.atlassian.net/browse/BVTCK-57

I've replaced those before methods which were preparing validators with BaseExecutableValidatorTest and BaseValidatorTest classes. Adding webArchiveBuilder util method was caused by the java.lang.ClassNotFoundException when running tests from setup-examples/maven.

One more @BeforeMethod remains in ExpressionLanguageMessageInterpolationTest where it is used for setting up a locale.

marko-bekhta commented 7 years ago

Hi @gunnarmorling. Just signed CLA for BV. And while doing that I saw that for HV the status is Awaiting approval by community lead. Is that OK ?

gunnarmorling commented 7 years ago

Thanks, Marko, the paper work is fine. Rebased and applied.

As a follow-up it'd be great to prevent any new usages of @BeforeMethod. CheckStyle offers that functionality via its ImportControl check, but I failed to make that work. An alternative may be this tool https://github.com/policeman-tools/forbidden-apis which I think we already use in HSEARCH.

marko-bekhta commented 7 years ago

@gunnarmorling OK, I'll look into this