search

jake-hansen / nova

NOVA project for Software Engineering at UNO.
1 stars 0 forks source link

Feature/show me all my lost and injured children and send word that i am coming #53

Closed bknutson77 closed 4 years ago

bknutson77 commented 4 years ago

Tests the functionality of the first responder updates and SOS/Lost Dashboard.

bknutson77 commented 4 years ago

Logic functions as expected. I noticed that logic could be greatly simplified across the webapp if there was a way to get user status information directly from a user object. I added this functionality with a new commit and simplified the logic in GetAllLostAndInjured.java and firstresponders.jsp quite a bit.

Let me know what you think.

Thanks! Yeah I was just trying to get it done asap, wasn't really trying to beautify the code. Looks good

gomezem commented 4 years ago

Everything worked for me. I noticed this in other classes, but maybe we can do one more PR on making sure all of our classes have comments?

jake-hansen commented 4 years ago

Everything worked for me. I noticed this in other classes, but maybe we can do one more PR on making sure all of our classes have comments?

Yes I like this idea.