search

jake-phy / WindowIconList

GNU General Public License v2.0
75 stars 26 forks source link

Fixed bug: App icon not removed from a panel #104

Closed cardsurf closed 8 years ago

cardsurf commented 8 years ago

:beetle: Description: App icon is not removed from a panel when using more than one workspace.

Details: "notify::state" signal is not being sent because there are opened app windows in other workspaces.

Steps to reproduce:

  1. Open an unpinned app window in the first workspace. For example open a terminal window in the first worskpace.
  2. Switch to the second workspace: Ctrl+Alt+→
  3. Open a terminal window in the second workspace.
  4. Close the terminal window in the second workspace.

Actual result: Terminal icon remains on a panel in the second workspace.

Expected result: Terminal icon is removed from a panel in the second workspace.

Solution: Connect "windows-changed" signal. A signal handler is called when app window is opened or closed. Remove app icon from a panel if there is no app window in the workspace.

jake-phy commented 8 years ago

Nicely done, this was one of the bugs I was hung up on. thanks.