jake-phy / WindowIconList

GNU General Public License v2.0
75 stars 26 forks source link

Windows sometimes require 2 clicks to open instead of 1 #106

Closed frane-giscloud closed 8 years ago

frane-giscloud commented 8 years ago

Windows sometimes require 2 clicks to open instead of 1.

OS: Linux mint 17.2 Cinnamon: 2.6

frane-giscloud commented 8 years ago

I've taken a peak, and saw that the _onAppButtonRelease doesn't get triggered on unopened favorites. Only for the first time, but then it works fine.

frane-giscloud commented 8 years ago

The issue is resolved:

344c344
<         this.parentActor.connect('button_press_event', Lang.bind(this, this._onButtonPress));
---
>         this.parentActor.connect('button-release-event', Lang.bind(this, this._onButtonPress));
349c349
<         this.actor.connect('button_press_event', Lang.bind(this, this._onButtonPress));
---
>         this.actor.connect('button-release-event', Lang.bind(this, this._onButtonPress));

You only need to change the event in SpecialMenus,js from button-release-even > button_press_event.

samogot commented 8 years ago

this issue is dublicate of #101 @frane-giscloud, thx for the fix

jake-phy commented 8 years ago

Confirmed fixed, thanks for implementing that guys.