Big issue with the latest release!!!

[freemangilgamesh]

Why did you mess up a nice applet!!!!!!!!!!!!!!!!!!!!!! It does not work anymore on Linux Mint 17: I can no longer pin applets to it from "configurable menu" and when I try to I get a displaced applet!!!!!!!!!!!!!!!!!!!!!!! The last update is so unnecessary and a mistake!!

[jake-phy]

Huh what's going on can you give me some more detail?

-----Original Message----- From: "Brahim Salem" notifications@github.com Sent: ‎7/‎25/‎2014 10:37 PM To: "jake-phy/WindowIconList" WindowIconList@noreply.github.com Subject: [WindowIconList] Big issue with the latest release!!! (#48)

Why did you mess up a nice applet!!!!!!!!!!!!!!!!!!!!!! It does not work anymore on Linux Mint 17: I can no longer pin applets to it from "configurable menu" and when I try to I get a displaced applet!!!!!!!!!!!!!!!!!!!!!!! The last update is so unnecessary and a mistake!!

— Reply to this email directly or view it on GitHub.

[jake-phy]

Should work fine twas my bad. Missed one little thing sorry. should be fixed

[ghost]

@jake-phy he refers to this: https://github.com/lestcape/WindowIconList/commit/90f90e4308ed616063e1012f52833dda4dfa5a51

@freemangilgamesh not be such a baby... The update is necessary and sure will be much better for the next. Now at least you can report an error on github without @mtwebster telling you, that you need to take off all buggy applets first.

[ghost]

@jake-phy And well, you can also export the appFavoritesInstance directly from your applet, without applet manager... I can access to your applet using this code for the next configurable menu version to if you don't want to support the old way, will be your decision.

[ghost]

@jake-phy i think that will be better with this: https://github.com/lestcape/WindowIconList/commit/377126342fa1830581963be0db50b4fb9c6ffc63 way...

[jake-phy]

@freemangilgamesh Should be working fine now can you update?

[freemangilgamesh]

Thank you guys now it works out of the box with configurable menu but i still can't use it with the default Cinnamon menu! But it is great still!

[jake-phy]

The cinnamon menu doesn't integrate with most third party applet that i know of. Sorry.

-----Original Message----- From: "Brahim Salem" notifications@github.com Sent: ‎7/‎26/‎2014 1:36 PM To: "jake-phy/WindowIconList" WindowIconList@noreply.github.com Cc: "jake-phy" jake.phy@gmail.com Subject: Re: [WindowIconList] Big issue with the latest release!!! (#48)

Thank you guys now it works outof the box with configurable menu but i still can't use it with the default Cinnamon menu! But it is great still! — Reply to this email directly or view it on GitHub.

[ghost]

@freemangilgamesh if you really want this, you need to open an issues on cinnamon: Cinnamon panel launcher will be open also if it's closed by user, this is not necesary when user deside do not active the panel launcher applet an cause problem to user that not want to open the panel launcher.

[jake-phy]

You can also just drag and drop application from any menu to the window list to pin them.

[ghost]

@jake-phy you have more than one way to do that.

1- You can use as favorites(pined) apps, the panel launcher apps, so when cinnamon menu added an app to panel launcher you also can capture this. Just for me the best way, because like i see, have not sence this two applets at the same time and you can use the implementation code of cinnamon menu to also add application to your panel.

global.settings.get_strv('panel-launchers');

2- I don' t like this implementation because can cause a problem to decide if app it' s in panel or not because panel launcher and your applet work similar in this case.

Edit: (just one line more)

this.panelApp = global.settings.get_strv('panel-launchers');
global.settings.connect('changed::panel-launchers', Lang.bind(this, this._appAddedToPanel));

_appAddedToPanel: function() {
        let newPanelApp = global.settings.get_strv('panel-launchers');
        for(let i in newPanelApp) {
            if(this.panelApp.indexOf(newPanelApp[i]) == -1) {
                this.pinnedAppsContr.addFavorite(newPanelApp[i]);
            }
        }
        for(let j in this.panelApp) {
            if(newPanelApp.indexOf(this.panelApp[i]) == -1) {
                this.pinnedAppsContr.removeFavorite(newPanelApp[i]);
            }
        }
        this.panelApp = newPanelApp;
    },

[ghost]

@freemangilgamesh this code need to be removed from cinnamon menu applet:

/* if(!Main.AppletManager.get_object_for_uuid("panel-launchers@cinnamon.org")) {
               var new_applet_id = global.settings.get_int("next-applet-id");
               global.settings.set_int("next-applet-id", (new_applet_id + 1));
               var enabled_applets = global.settings.get_strv("enabled-applets");
               enabled_applets.push("panel1:right:0:panel-launchers@cinnamon.org:" + new_applet_id);
               global.settings.set_strv("enabled-applets", enabled_applets);
            }*/

[ghost]

There are now a way to be compatible with Cinnamon Menu Applet, thanks to @mtwebster. He created a way to linking this type of thing with external applets like this. I will try to make a pull request with this change, but need to be revised, sure could be improved or adjust to be better for the thing that @jake-phy expected.

[ghost]

@jake-phy about the drag and drop, to panel. Like you say "You can also just drag and drop application from any menu to the window list to pin them." Yes, but you can drag and drop a Desklet to your panel also. The solution of this need to be implemented in cinnamon code, like i propouse, here: https://github.com/linuxmint/Cinnamon/issues/3393 but at less could be good that you do not acepted dropped of actors that are instance of Desklets for now at less...

[mtwebster]

What I sort of envisioned when I did the last set of changes, is eventually, any applet/desklet that wants to can implement DND.LauncherDraggable on their launcher 'objects,' and they can be dragged to any applet that will accept LauncherDraggable (the only requirement is they provide a getId() method to return the .desktop path). It's only implemented with the panel launcher for now, as I needed to take care of other stuff, but I could see fixing up the launcher desklet to work with this, or interaction between window list applets and launchers, etc..

[ghost]

upsss. I really not see all your code @mtwebster only the menu applet... this look like a good thing that i want to see also... I hope that i can test this soon.