search

jake-phy / WindowIconList

GNU General Public License v2.0
75 stars 26 forks source link

"Random" highlighting of icons #51

Closed JakubRimal closed 8 years ago

JakubRimal commented 10 years ago

I found that sometimes some app icons are highlighted when they shouldn't be.

How to reproduce it:

  1. start some apps (for example I have opened Firefox, Banshee, Skype, Sublime and Thunderbird)
  2. go to Thunderbird (or other app...) and click on some link which will be opened in Firefox
  3. Icons for Banshee, Skype and Sublime are highlighted. snimek obrazovky porizeny 2014-08-30 22 40 48

What "highlighted" means: Icons will have style of "window-list-item-demands-attention" class, which is defined in ~/.themes/yourTheme>/cinnamon/cinnamon.css

Because it is really annoying, I have commented out definition of "window-list-item-demands-attention" class as a workaround.

Version info: Window List with App Grouping 2.7.5 Linux Mint 17 Cinnamon 64-bit

jake-phy commented 10 years ago

Yes this is really annoying working on a fix. thanks for reporting.

jake-phy commented 10 years ago

This should be fixed in the git version now, but I'm not sure if is ever highlighted now. want to test it?

JakubRimal commented 10 years ago

Hi, I've just tested it and it looks like nothing is highlighted also when it should be – e.g. when message to the Pigdin is received.

jake-phy commented 10 years ago

Thanks. That is what I was afraid of. I will keep working on it.

jake-phy commented 9 years ago

Are you willing to test the Dev branch again? I can't get the notifications to even work for the normal window list. Not sure what is wrong.

JakubRimal commented 9 years ago

Yes, I can confirm that it probably doesn't work in default Window List applet, so I think that it can't work with your applet. But for me is Window List with App Groupin unusable now because of it does no action onclick on app icon. So now I use default Window List applet. Thank you for your work!

jake-phy commented 9 years ago

You can change that in the settings :).

-----Original Message----- From: "JakubRimal" notifications@github.com Sent: ‎3/‎16/‎2015 4:07 PM To: "jake-phy/WindowIconList" WindowIconList@noreply.github.com Cc: "jake-phy" jake.phy@gmail.com Subject: Re: [WindowIconList] "Random" highlighting of icons (#51)

Yes, I can confirm that it probably doesn't work in default Window List applet, so I think that it can't work with your applet. But for me is Window List with App Groupin unusable now because of it does no action onclick on app icon. So now I use default Window List applet. Thank you for your work! — Reply to this email directly or view it on GitHub.

JakubRimal commented 9 years ago

Sorry, I have no idea how to do it. It looks like click doesn't work during animation of showing of thumbnail. This is probably the only one settings how to avoid this very uncomfortable behaviour: snimek obrazovky porizeny 2015-03-16 22 17 20

jake-phy commented 9 years ago

Weird it looks like everything is right there. One other user reported that the windows are not opening right away when they clicked.

-----Original Message----- From: "JakubRimal" notifications@github.com Sent: ‎3/‎16/‎2015 4:19 PM To: "jake-phy/WindowIconList" WindowIconList@noreply.github.com Cc: "jake-phy" jake.phy@gmail.com Subject: Re: [WindowIconList] "Random" highlighting of icons (#51)

Sorry, I have no idea how to do it. It looks like click doesn't work during animation of showing of thumbnail. This is probably the only one settings how to avoid this very uncomfortable behaviour:

— Reply to this email directly or view it on GitHub.

JakubRimal commented 9 years ago

Ok after some tests it seems like it really depends on Thumbnail timeout setting – when I click around the time which is set in the settings, the click has no action.

jake-phy commented 9 years ago

You know what that could be. I never thought of that!!! I'll look into it this evening.

-----Original Message----- From: "JakubRimal" notifications@github.com Sent: ‎3/‎16/‎2015 4:30 PM To: "jake-phy/WindowIconList" WindowIconList@noreply.github.com Cc: "jake-phy" jake.phy@gmail.com Subject: Re: [WindowIconList] "Random" highlighting of icons (#51)

Ok after some tests it seems like it really depends on Thumbnail timeout setting – when I click around the time which is set in the settings, the click has no action. — Reply to this email directly or view it on GitHub.

JakubRimal commented 9 years ago

Are you willing to test the Dev branch again? I can't get the notifications to even work for the normal window list. Not sure what is wrong.

Now I know how to get notifications: in Pidgin go to Tools > Plugins and enable Message notification plugin (not sure the exact name because I have it in Czech). After that Window list should get the .window-list-item-demands-attention CSS class when new message appears.

jake-phy commented 8 years ago

This has been fixed in dev.