search

jake-phy / WindowIconList

GNU General Public License v2.0
75 stars 26 forks source link

Some cleanup. Maybe even a minor bugfix - bad variable name. #53

Closed aikeru closed 9 years ago

aikeru commented 9 years ago

Hey! You have an awesome project. I use it exclusively on my work machine with Mint 17. I found some missing semicolons, some ambiguous use of ==, some leaked global variables, and even what looked like a bad variable name (bug).

I'd like to help and contibute so I thought a good way would be to help and learn about this project would be to clean up some of the code.

jake-phy commented 9 years ago

Thanks I have never understood the triple = before. And if you could switch it to groupApps === false I will merge it right away. Otherwise if you turn group apps off, I don't think the windows apps will show. Want something else to to work on? Do you have any idea how to keep a popupmenu open after removing an child from the menu? I can't figure out why it is closing.

aikeru commented 9 years ago

Whoops! Good catch, I actually reversed the condition by mistake. I've updated the pull request.

As for the popup menu, I am not familiar with the gnome APIs but I wouldn't mind trying as much as I have time.

Can you point me in the right direction where the body of the code is that affects this part of the app?

jake-phy commented 9 years ago

Thanks. The code for the PopupMenu is under /usr/share/cinnamon/js/ui/popupMenu.js.
Yes I know "oh for more time". Don't kill yourself trying to figure it out ;)