Add Close All and some cleanup

jake-phy / WindowIconList

GNU General Public License v2.0

75 stars 26 forks source link

Add Close All and some cleanup #58

Closed aikeru closed 9 years ago

aikeru commented 9 years ago

Correct typo in applet.js (metewindow to metaWindow)
Add "Close All" right-click menu option
mostly normalize spacing in specialMenuItems.js (looks fine in vim with settings but before this looked very wrong in github, because a mixture of spaces/tabs was used)

I have tested the "Close All" locally and I am currently using this commit on my own machine. Resolve #57

jake-phy commented 9 years ago

Really appreciate what you are doing here thanks.

aikeru commented 9 years ago

Glad I can participate :) its fun to help out when I can. I added as a new additional menu item. If some users don't like maybe it can be optional in settings. I haven't looked at settings code much in GJS applets.

aikeru commented 9 years ago

@jake-phy I have made Close All optional, and not on by default.

jake-phy commented 9 years ago

Awesome. I do not implement the settings api the way it is meant to be since I have everything split up. Sometime i'm going to have to get ambitious and rewrite the whole applet.

-----Original Message----- From: "aikeru" notifications@github.com Sent: ‎9/‎22/‎2014 6:23 PM To: "jake-phy/WindowIconList" WindowIconList@noreply.github.com Cc: "jake-phy" jake.phy@gmail.com Subject: Re: [WindowIconList] Add Close All and some cleanup (#58)

@jake-phy I have made Close All optional, and not on by default. — Reply to this email directly or view it on GitHub.=