search

jake-phy / WindowIconList

GNU General Public License v2.0
75 stars 26 forks source link

Looks weird on HiDPI display #87

Open anandtrex opened 9 years ago

anandtrex commented 9 years ago

See attached image. WindowIconList looks really weird on a HiDPI display (2560x1440 14") compared to the normal window list shown next to it for comparison.

windowiconlist-hidpi-screenshot

jake-phy commented 9 years ago

hmm that is weird. Not sure why the icons are squished.

xcjs commented 9 years ago

I don't know if this is the correct answer (I've never done Cinnamon applet development) but I was aware that GTK 3 extensions were written in JavaScript so I decided to investigate.

While I don't understand the underlying cause, this is triggered by not explicitly setting the button width. I took a look at specialButtons.js and added the following code after line 60:

this.actor.height = parent._applet._panelHeight - 2;
this.actor.width = parent._applet._panelHeight * 1.25;

The buttons are roughly (very roughly since I only did it by sight) 1.25 times wider than they are tall. After modifying the extension as mentioned, things seem to work out pretty well.

Should I make a pull request?

jake-phy commented 8 years ago

yeah go ahead and I will take a look. sorry it took 5 months to reply :(.

grenzor commented 8 years ago

Also facing this issue with HiDPI. @jake-phy possibly you can take @xcjs solution up?

jake-phy commented 8 years ago

Ok can you try now? Make sure you use the develop branch.

grenzor commented 8 years ago

Using the dev branch, the icons are still appearing as large x