jakeajames / noNotch

Remove notches from iPhone X
22 stars 9 forks source link

Cannot build with Theos #5

Open artillect opened 6 years ago

artillect commented 6 years ago

I've installed Theos on my iPhone 8+ on iOS 11.3.1 and have attempted to build noNotch with both the iOS 11.2 SDK and 9.3 SDK but all I get are errors saying that UIAccelerometer is deprecated and has been replaced with the CoreMotion framework.

Here's a log with the errors: https://pastebin.com/z36s4cKu

Why wasn't CoreMotion used in the first place? It makes no sense to use something that's been deprecated for almost 7 years. How can I go about fixing this and how can we bring the project up-to-date with the current standards set by Apple?

jakeajames commented 6 years ago

I don't get these errors, not even warnings.

Il sabato 14 luglio 2018, Riley (Artillect) notifications@github.com ha scritto:

I've installed Theos on my iPhone 8+ on iOS 11.3.1 and have attempted to build noNotch with both the iOS 11.2 SDK and 9.3 SDK but all I get are errors saying that UIAccelerometer is deprecated and has been replaced with the CoreMotion framework.

Here's a log with the errors: https://pastebin.com/z36s4cKu

Why wasn't CoreMotion used in the first place? It makes no sense to use something that's been deprecated for almost 7 years. How can I go about fixing this and how can we bring the project up-to-date with the current standards set by Apple?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jakeajames/noNotch/issues/5, or mute the thread https://github.com/notifications/unsubscribe-auth/ATtX-QGG3TySy2JmtwXeP4vzrzlI7Ylfks5uGYeZgaJpZM4VPvYU .

jakeajames commented 6 years ago

Anyway you can fix it by adding this to CFLAGS on Makefile:

-Wno-deprecated-declaration

Il sabato 14 luglio 2018, Jakea Hacks jakeashacks@gmail.com ha scritto:

I don't get these errors, not even warnings.

Il sabato 14 luglio 2018, Riley (Artillect) notifications@github.com ha scritto:

I've installed Theos on my iPhone 8+ on iOS 11.3.1 and have attempted to build noNotch with both the iOS 11.2 SDK and 9.3 SDK but all I get are errors saying that UIAccelerometer is deprecated and has been replaced with the CoreMotion framework.

Here's a log with the errors: https://pastebin.com/z36s4cKu

Why wasn't CoreMotion used in the first place? It makes no sense to use something that's been deprecated for almost 7 years. How can I go about fixing this and how can we bring the project up-to-date with the current standards set by Apple?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jakeajames/noNotch/issues/5, or mute the thread https://github.com/notifications/unsubscribe-auth/ATtX-QGG3TySy2JmtwXeP4vzrzlI7Ylfks5uGYeZgaJpZM4VPvYU .

artillect commented 6 years ago

Disabling the error in your makefile isn't really a fix, the code should really be written using the current standard.

jakeajames commented 6 years ago

i don't like the current standard, especially when Apple itself uses "deprecated" code on iOS

2018-07-15 19:07 GMT+02:00 Riley (Artillect) notifications@github.com:

Disabling the error in your makefile isn't really a fix, the code should really be written using the current standard.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jakeajames/noNotch/issues/5#issuecomment-405104496, or mute the thread https://github.com/notifications/unsubscribe-auth/ATtX-fdxco-hRpx-oItbtldgpTP8b_NRks5uG3bIgaJpZM4VPvYU .

jakeajames commented 6 years ago

Hello. I'm seeing your comments on Discord.

If you wanna learn don't use noNotch. Some parts of the code will confuse everyone and only I know why they're there (i.e. "if oldOrientation != 1").

For learning purposes you can check out TimeToUnlock, RealCC, ActivatorFix, my Reverse-Engineering repo etc. Older my projects are more messy they are. noNotch at first was built for me to play with the iPhone X simulator.

Regards

artillect commented 6 years ago

Thanks for the advice, I'll go check out the projects you recommended.