search

jakearchibald / idb-keyval

A super-simple-small promise-based keyval store implemented with IndexedDB
Other
2.74k stars 147 forks source link

Error in require() in version 5.1.0 #122

Closed tomdrewes closed 3 years ago

tomdrewes commented 3 years ago

We are building a project that uses idb-keyval via require()/browserify and we recently noticed this error that seemed to come along with the changes in 5.1.0:

Error: Cannot find module 'dist/cjs-compat/index.js' from '/Users/tdrewes/Code/serenity-clean/inara/node_modules/idb-keyval/dist/cjs-compat'

In looking at dist/cjs-compat/index.js it appears that on line 9: var safariFix = require('dist/cjs-compat/index.js');

there may be a typo which is supposed to be referencing the source for the recent Safari bug workaround.

jakearchibald commented 3 years ago

Ugh, sorry, schoolboy error from me. I'll ship a fix tomorrow.

jakearchibald commented 3 years ago

Thank you for filing an issue on this!

jakearchibald commented 3 years ago

Should be fixed in 5.1.1. Let me know if there are any issues.

Closed in a2f76a455d6647b0d6639ed252b27f9190b8e720