search

jakearchibald / idb

IndexedDB, but with promises
https://www.npmjs.com/package/idb
ISC License
6.29k stars 353 forks source link

polyfill getAllKeys for EDGE & IE #180

Closed litt1e-p closed 3 years ago

litt1e-p commented 4 years ago

why not implement polyfill getAllKeys for EDGE & IE on tag v3.0.x? just like polyfill getAll

jakearchibald commented 4 years ago

I didn't want to bloat the library for folks that were using modern browsers. The library doesn't support IE from 4.x onwards due to reliance on proxy objects.

Edge supports getAllKeys from 79 onwards.

jakearchibald commented 4 years ago

Oh, I just realised you're asking specifically for an addition to 3.x. Um, I guess I felt it wasn't common enough to add. You're the first person asking for it.

litt1e-p commented 4 years ago

yeah, idb is great. I am using it in vue 2.6.x, my project must supports Edge 44+ & IE for some reasons. I had tried to make a pull request with tag v3.0.3, but failed.

jcgiuffrida commented 4 years ago

For Edge specifically, I''m using indexeddb-getall-shim with idb@5 and it works fine on Edge v44. Edge doesn't have getKey but you can just use count instead.

jakearchibald commented 3 years ago

I'm not actively maintaining the old versions (although I'll fix bugs in some cases), so I'm going to close this.