search

jakearchibald / idb

IndexedDB, but with promises
https://www.npmjs.com/package/idb
ISC License
6.29k stars 353 forks source link

This change is more universally compilable. #193

Closed tom-huguenard closed 4 years ago

tom-huguenard commented 4 years ago

Not sure if this works. Not sure what it does. But it allows my code to compile and run, so I submit it might be good. Have a look! Thanks!

jakearchibald commented 4 years ago

I guess you're targeting a system that doesn't support object spread.

To keep the library small, I'm keeping the JavaScript here as modern is possible. Folks can use Babel etc to transpile it down to their taget.

tom-huguenard commented 4 years ago

No problem. Can you include instructions on how to transpile your modern code? I am using Babel and configuration documentation is murky at best. I use the spread operator, but one of my dependencies doesn't seem to understand it, so your awesome code is failing as shipped.

tom-huguenard commented 4 years ago

And thanks for replying so generously. btw...

jakearchibald commented 4 years ago

Which bundler are you using?

tom-huguenard commented 4 years ago

nvm. Thanks. I was just trying to suggest how you might update your docs. Peace...

jakearchibald commented 4 years ago

oh ok