search

jakearchibald / idb

IndexedDB, but with promises
https://www.npmjs.com/package/idb
ISC License
6.29k stars 353 forks source link

openDB version parameter should be optional #196

Closed asiaracz closed 3 years ago

asiaracz commented 3 years ago

In the original indexedDB API, the version parameter of the open function is optional: https://developer.mozilla.org/en-US/docs/Web/API/IDBFactory/open

It would be good if the openDB function also allowed not passing the version.

enguerran commented 3 years ago

I came across this need. Glad to see that a ticket has already been opened and that there is even a PR to correct the library. Thank @asiaracz for your work!

I checked if the PR was released and found 5.0.5 to have this change: https://github.com/jakearchibald/idb/blob/v5.0.5/src/entry.ts#L45

but not in builds:

Is it an oversight or are builds delivered later?

jakearchibald commented 3 years ago

This is an oversight. Thanks for the heads-up. I'll fix it.

jakearchibald commented 3 years ago

Published as 5.0.6.