search

jakearchibald / idb

IndexedDB, but with promises
https://www.npmjs.com/package/idb
ISC License
6.34k stars 357 forks source link

Async iterators are now supported by Edge #255

Closed nornagon closed 10 months ago

nornagon commented 2 years ago

It looks like Edge now supports async iterators: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for-await...of

Perhaps they could be folded into the main bundle now?

yw662 commented 2 years ago

Is there still "Edge" anyway ?

jakearchibald commented 2 years ago

I think this is a reasonable consideration. Although, it's kinda nice to have a smaller bundle if you don't need async iterators. I'll think it through.

nornagon commented 2 years ago

IMO the extra bundle size isn't worth the "huh?" when you try to use async iterators as listed in the docs but they don't work because you missed the bit where you have to import a different package. Let tree shaking work it out for folks who care about bundle size, no?

jakearchibald commented 2 years ago

That isn't how tree shaking works unfortunately

jakearchibald commented 10 months ago

Fixed in https://github.com/jakearchibald/idb/pull/302