search

jakearchibald / svgomg

Web GUI for SVGO
https://jakearchibald.github.io/svgomg/
MIT License
5.8k stars 482 forks source link

pan-zoom.js: remove Firefox workaround #354

Closed XhmikosR closed 1 year ago

XhmikosR commented 3 years ago

Not sure what exactly this was supposed to fix/work around, but it might not be needed anymore?

netlify[bot] commented 3 years ago

Deploy Preview for svgomg ready!

Name Link
Latest commit c0e9a447e3dae72a84b1b4a888f3ad621a8b5a70
Latest deploy log https://app.netlify.com/sites/svgomg/deploys/635a97392e68060008842e8e
Deploy Preview https://deploy-preview-354--svgomg.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

jakearchibald commented 3 years ago

It seems like this is still an issue pretty recently https://github.com/pmndrs/use-gesture/issues/236. I can't recreate it locally, but maybe it depends on the type of mouse, or maybe Firefox changed things more recently, but I can't find anything in their bug tracker about it.

XhmikosR commented 3 years ago

We can put this on hold if you think it's better. I couldn't replicate the issue personally using the latest Firefox.

jakearchibald commented 3 years ago

I couldn't replicate it either, but unlike https://github.com/jakearchibald/svgomg/pull/355, the thing being removed in this PR addresses a feature, not a bug. That feature still exists. https://github.com/pmndrs/use-gesture/issues/236 suggests it's recently used in the wild.

Yeah, I don't think we should ship this change.

XhmikosR commented 3 years ago

Marked the PR as draft.

Perhaps we should then change the comment? I'm fine with dropping this patch, I was just going through the codebase for stuff that might be outdated :)

jakearchibald commented 3 years ago

Yeah, changing the comment sounds good. Something that communicates:

Maybe include https://github.com/pmndrs/use-gesture/issues/236 for reference