Easier copy/paste from the markup screen

gucr commented 1 year ago

This pull request goal is to improve the user experience when copying the markup code in the markup screen. As of today (and discussed in issue #22) some UI text gets copied along with the SVG markup when we use the keystrokes CMD+A —> CMD+C.

There is multiple ways to solve the issue:

Excluding UI elements with user-select:none. Meaning that it will need to be specified if new UI regions appear in the future
Excluding the whole app with user-select:none, and allowing some UI regions with with user-select:auto
Making the output div contentEditable="true" but this requires to deactivate autocorrect, autocapitalize & so on. Also, this could lead to side effects whenever the contentEditable API evolves.
For the future: using user-select:contain. This is CSS4 spec as we speak and not yet supported by any browser.

I went with the 1st solution (excluding .main-menu and .action-button-container) but I can adjust if needed

netlify[bot] commented 1 year ago

Deploy Preview for svgomg ready!

Name	Link
Latest commit	4799b2615380239f0e86fee86c16355b23b697ca
Latest deploy log	https://app.netlify.com/sites/svgomg/deploys/63eda8eb4bd65e0008778620
Deploy Preview	https://deploy-preview-419--svgomg.netlify.app/
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

XhmikosR commented 1 year ago

It still isn't the proper way IMHO.

jakearchibald / svgomg