search

jakeday / linux-surface

Linux Kernel for Surface Devices
2.6k stars 245 forks source link

Help Requested: Upstreaming Kernel Changes for Surface Devices #292

Open aboimpinto opened 5 years ago

aboimpinto commented 5 years ago

Do you think that you propose merge your changes to thew new kernels? What do you think is necessary to processed with this?

Isn't Microsoft interested in push this to the linux kernel?

this project will continue to be a pet project or will have a bigger expose?

tkx for all and keep up the good work Paulo Aboim Pinto

lucasvanlierop commented 5 years ago

Isn't Microsoft interested in push this to the linux kernel?

I've read @brendandburns is trying to get Microsoft to contribute to this project: https://twitter.com/brendandburns/status/1046929893575946240

aboimpinto commented 5 years ago

that is good news ... I can we influence this push?

qzed commented 5 years ago

I can only speak for myself here, but I'd love to get this all upstream once it's mature enough. As to what that takes: It depends on the thing in question.

For the SB2/SP17/Laptop button support I'm currently only waiting to find finally the time to inform myself about how to do this and then get started with the whole process.

For the ACPI Notify driver I'm also working on, things are different. That thing isn't just an addition, but it also relies on some patches to fix some issues (including one similar to something already proposed upstream and then reverted), so there will be more work involved (also it's not even quite ready to be included in this repo, but I'm working on that part).

For parts I'm not that familiar with: IPTS. As far as I know, the patch in this repo is based on https://github.com/ipts-linux-org/ipts-linux-new, which seems to be initially provided by some Intel employee, but since then (late 2016) there has been nothing official (from either Intel or MS) that I'm aware of. So I doubt that this will end up in the kernel any time soon.

I'd really love some official support, heck I'd be already happy if I could get some documentation for the 5th gen. Surface devices (specifically the embedded controller accessed via the Surface Serial Hub / Surface ACPI Notify driver), as I'm currently just winging that based on some logs and testing. It would also be nice if we could get s2idle to work, official support could help there too. (If anyone has some MS connections beyond customer support and thinks they're willing to help...)

aboimpinto commented 5 years ago

Tkx very much for your reply you gave all the information that I was asking. You need help to get some support and I believe the community can try to get that. For sure there is someone that know someone that know someone inside Microsoft to provide some support... who know even official support.

Keep this issue open for anyone to see and help if can...

tkx very much for the good work Paulo Aboim Pinto

jakeday commented 5 years ago

I changed the title of this issue and will leave it open! I'd love to see all of these changes upstreamed as well!

brendandburns commented 5 years ago

@qzed I just saw this. Send mail to bburns [at] microsoft [dot] com and I'll see if I can connect you with the surface hardware team...

No promises, it's a giant corp and I'm on the Azure side, not the Surface side, but I will try.

(and I run these kernels on my daily driver for my Azure work so... :)

qzed commented 5 years ago

@brendandburns Awesome, thanks!

No promises, it's a giant corp and I'm on the Azure side, not the Surface side, but I will try.

Nevertheless much appreciated!

savely-krasovsky commented 5 years ago

@brendandburns Any news? I know that you didn't promise anything, just asking, maybe you have something to share with us.

grokkingStuff commented 5 years ago

@brendandburns

Hey there! Any luck so far?

damianatorrpm commented 4 years ago

Maybe you should just send them to the kernel mailing list 1 by 1 to get them merged.

qzed commented 4 years ago

@damianatorrpm I'm working on it that way. The ethernet stuff for the dock has been integrated a while ago and button patches will be in 5.4. Unfortunately the ACPI stuff relies on a bug within the Microsoft ACPI implementation (or rather it's not behaving up to the specification), which either has to be "emulated" in Linux or fixed and changed in the ACPI code. I'm currently awaiting a response from an Intel dev working on the Linux ACPICA implementation. If that is done, then the ACPI address space subsystem requires some work that I haven't gotten to yet. So it's getting there, but the larger stuff is going slowly. We're also working on getting IPTS in a better shape, but there's still a long way to go before I think it can go upstream.