Bootstrap

[jakee246]

@chrisvfritz is this correct?

[chrisvfritz]

Not quite. You should use the latest version of bootstrap-sass in your Gemfile, then look at their README for instructions on integrating it into Rails.

[jakee246]

@chrisvfritz It should be correct now.

[chrisvfritz]

Better, but Bootstrap's JavaScript still isn't being included in the app. The last part of the Ruby on Rails section in those docs has instructions for how to include it.

[jakee246]

Now we should be good to go.

On Wed, Apr 22, 2015 at 3:09 PM, Chris Fritz notifications@github.com wrote:

Better, but Bootstrap's JavaScript still isn't being included in the app. The last part of the Ruby on Rails section in those docs has instructions for how to include it.

— Reply to this email directly or view it on GitHub https://github.com/jakee246/tc359finalproject/issues/1#issuecomment-95307046 .

[chrisvfritz]

Unfortunately, that isn't the right way to include Bootstrap's JS via the bootstrap-sass gem. With your way, updating the gem will still leave you with an old version of Bootstrap's JS.

The third-to-last paragraph in these docs describes how to properly include it.

[jakee246]

@chrisvfritz never received feedback on this. Thank you.

[chrisvfritz]

Ah, I only know to take another look when you've posted a comment mentioning me. You still need to delete your manually added version of Bootstrap's JS here. Then in your application.js file, this line should be above //= require_tree .. For future reference, require_tree adds all the JavaScript in your javascripts folder, so 3rd-party assets should always appear above the require_tree, so that you can access those libraries from your own code.

[jakee246]

@chrisvfritz fixed

[chrisvfritz]

This looks good now, but it was posted past the deadline on Friday, so I'm not able to give you credit for it unfortunately. Sorry. :disappointed:

[jakee246]

We went through these together in case on that Monday and I had thought gotten the green light from you before I left. My confusion is holding me from obtaining a 3.5 now correct?

On Sun, May 3, 2015 at 7:17 PM, Chris Fritz notifications@github.com wrote:

This looks good now, but it was posted past the deadline on Friday, so I'm not able to give you credit for it unfortunately. Sorry. [image: :disappointed:]

— Reply to this email directly or view it on GitHub https://github.com/jakee246/tc359finalproject/issues/1#issuecomment-98555654 .

[chrisvfritz]

Ah, I didn't remember that we went through them on Monday. I just looked at the commit time. I'm happy to award the points in that case. :+1:

[jakee246]

Thank you very much!!

On Sun, May 3, 2015 at 7:43 PM, Chris Fritz notifications@github.com wrote:

Ah, I didn't remember that we went through them on Monday. I just looked at the commit time. I'm happy to award the points in that case. [image: :+1:]

— Reply to this email directly or view it on GitHub https://github.com/jakee246/tc359finalproject/issues/1#issuecomment-98557528 .