jakegiltsoff / sassline

Set text on the web to a baseline grid with Sass & rems using a responsive modular-scale.
https://sassline.com
1.38k stars 91 forks source link

Can't read modules import - libsass supported? #27

Closed ronilaukkarinen closed 8 years ago

ronilaukkarinen commented 9 years ago

Just cloned the repo, getting this:

[21:06:02] [gulp-sass] file to import not found or unreadable: modules/*.*
Current dir: /Users/rolle/Projects/dudetest/content/themes/dudestarter/sass/typography/sassline/assets/sass/ on line 13 in /Users/rolle/Projects/dudetest/content/themes/dudestarter/sass/typography/sassline/assets/sass/style.scss

It works with:

// Import all SCSS modules with Sass globbing.
@import "modules/footer";
@import "modules/globals";
@import "modules/header";
@import "modules/nav";
ronilaukkarinen commented 9 years ago

Oh, figured out this is a globbing thingy. Well, Gulp does not seem to have working globbing at the moment, I have already opened an issue here.

Nevertheless, isn't having to install a separate plugin for just one include a bit too overkill?

jakegiltsoff commented 9 years ago

@ronilaukkarinen I prefer to work in multiple scss partials so it is much nicer if they just get auto imported by globbing as outlined in the readme. If you dont then you can just run it without globbing as you have shown.

ronilaukkarinen commented 9 years ago

Ok, I'll have my way around gulp globbing. Thanks for the answer!

zacwasielewski commented 9 years ago

I second @ronilaukkarinen's issue. Sassline won't work with gulp/libsass, since libsass intentionally doesn't support globbing within partials. And unfortunately, there's no gulp plugin to work around the issue (I tried hacking gulp-css-globbing, but it's not a trivial change.)

@designbyjake, I totally understand your preference for auto imported globbing – I prefer it too. But with gulp and libsass gaining popularity, is there any chance you'd reconsider the tradeoff, simply because it will open up Sassline to gulp/libsass users?

(I'm personally handling it by maintaining a modified fork, but it sure would be nice to point my projects at the official repo. Oh, and thanks for your work on Sassline – it's really an awesome project!)

ronilaukkarinen commented 9 years ago

@zacwasielewski I agree. Didn't get my way around with libsass + globbing after all and ended up using modified fork myself as well, but it would be nice to use the official bower package without modifications and to get all the updates and keep the fiels clean in the future.

jakegiltsoff commented 9 years ago

Reopening, thinking on this some more.

jacmoe commented 8 years ago

If it helps your thinking, then I'd add that it goes against the rules set forth in the sass guidelines:

I would not recommend it because it imports files following the alphabetical order which is usually not what you want, especially when dealing with a source-order dependent language.

strarsis commented 8 years ago

For node_modules that aren't sass eyeglass compatible yet, you can use sass-include-paths which will autogenerate the right include paths for you.

With best regards

jakegiltsoff commented 8 years ago

I’m planning to removing globbing soon :+1:

jakegiltsoff commented 8 years ago

Globbing removed

ronilaukkarinen commented 8 years ago

It seems the npm package is not updated?

jakegiltsoff commented 8 years ago

@ronilaukkarinen Should be updated now!

ronilaukkarinen commented 8 years ago

Thank you @jakegiltsoff!