search

jakegiltsoff / sassline

Set text on the web to a baseline grid with Sass & rems using a responsive modular-scale.
https://sassline.com
1.38k stars 91 forks source link

bower package not working #30

Closed nevvkid closed 9 years ago

nevvkid commented 9 years ago

Hey. I just made a comment on the bower packaged pull request which was merged lately. The json doesn't seem to work as expected.

See the comment on the Pull request here: https://github.com/designbyjake/sassline/pull/29

mhumeSF commented 9 years ago

Looks like bower versioning requires version tagging to be x.y.z. On my fork I tagged the master branch as v2.1.0 and renamed the v2.0 to v2.0.0. I also updated the bower.json to include "main" and "ignore", but I dunno if they are needed. Also I don't think tags get pulled in a pull request so @designbyjake would have to retag 'em.

mhumeSF commented 9 years ago

@nevvkid Looks like version number have been added.

jakegiltsoff commented 9 years ago

@nevvkid @mhumeSF can you confirm this is working now?

mhumeSF commented 9 years ago

@designbyjake Yup, it's workin' :smile:

jakegiltsoff commented 9 years ago

:+1: Cheers @mhumeSF :)