jakegiltsoff / sassline

Set text on the web to a baseline grid with Sass & rems using a responsive modular-scale.
https://sassline.com
1.38k stars 91 forks source link

How about to remove vendor-prefix in SCSS files #33

Closed sotayamashita closed 8 years ago

sotayamashita commented 8 years ago

How about to add vendor-prefix during transferring scss to css ? I think it will be more simple

jakegiltsoff commented 8 years ago

@sotayamashita With something like Autoprefixer? https://github.com/postcss/autoprefixer

sotayamashita commented 8 years ago

@designbyjake Yes it is. What do think ?

Example:

// scss
selector {
  border-radius: 3px
}

↓ Transfer w/ build tool like gulp

/* css */
selector {
  -webkit-border-radius: 3px
     -moz-border-radius: 3px
          border-radius: 3px
}
jakegiltsoff commented 8 years ago

@sotayamashita I’ll think about it. I use it on other projects but didn’t want to add it as a dependency.

BTW border-radius doesn’t need prefixing ;)

sotayamashita commented 8 years ago

@designbyjake I got it.

BTW border-radius doesn’t need prefixing ;)

Oops... :sob:

jakegiltsoff commented 8 years ago

@sotayamashita I don’t think this should be closed yet.

sotayamashita commented 8 years ago

@designbyjake OK. but you do not want to add a dependencies ?

ambethia commented 8 years ago

I agree. I use autoprefixer, and I'd rather not see prefixes in sass dependencies. It might be useful to publish both a bare file and and pre-fixed file for different use cases.

jakegiltsoff commented 8 years ago

I’m planning to add autoprefixer soon :+1:

sotayamashita commented 8 years ago

@designbyjake Which browser will you support ? Example is below:

autoprefixer({ browsers: ['last 2 versions'] })

Here is browser list

KingScooty commented 8 years ago

Yep, +1 to removing prefixed code from this project.

jakegiltsoff commented 8 years ago

Autoprefixer added