search

jakegiltsoff / sassline

Set text on the web to a baseline grid with Sass & rems using a responsive modular-scale.
https://sassline.com
1.38k stars 91 forks source link

Make compatible with eyeglass #37

Closed strarsis closed 8 years ago

strarsis commented 8 years ago

Making this module eyeglass-ready makes it easy and consistent to install it from a npm package and import it in sass.

[https://github.com/sass-eyeglass/eyeglass](More information about eyeglass). eyeglass yeoman generator for easily preparing the project.

jakegiltsoff commented 8 years ago

@strarsis can you give anymore information as to what would be needed here?

strarsis commented 8 years ago

I prepared a PR: https://github.com/jakegiltsoff/sassline/pull/41

Besides eyeglass support, @importing the sassline-base.scss results in quite an amount of opinionated styles, is this intended?

You can try eyeglass support out:

npm install github:strarsis/sassline#master

You have to add sass-eyeglass to your sass build step of course.

jakegiltsoff commented 8 years ago

@strarsis Thank you for spending time on this, but I don’t feel the benefits of adding this will help many people compared to the additional complexity and maintenance it will require. I’m going to close this and the PR.