search

jakegiltsoff / sassline

Set text on the web to a baseline grid with Sass & rems using a responsive modular-scale.
https://sassline.com
1.38k stars 91 forks source link

Sassline mixin ignores the font type. #44

Open mitchrenton opened 8 years ago

mitchrenton commented 8 years ago

I've noticed that the sassline mixin ignores the font type.

For example...

@include sassline(18, $bodytype, 1.5, 1, all);

Outputs

line-height: 1.5rem; font-size: 1.5rem; margin-bottom: 0.74499rem; padding-top: 0.25501rem;

As well as the break point adjustments.

Whilst...

@include sassline(18, $headingtype, 1.5, 1, all);

Outputs the same.

Am I missing something?

jakegiltsoff commented 8 years ago

@mitchrenton Is that with the default fonts? If you alter the cap-height values in the variables they will be different.

paulhbarker commented 8 years ago

I'm having the same problem. I've switched out the defaults with my own and modified their cap-heights as well, but the mixin doesn't respect font type.

jakegiltsoff commented 8 years ago

@paulhbarker hmm, it does use the font’s defined cap-height in the equations so there may be a different issue causing what you are seeing. It could be an issue there seems to be with the minified css not updating every time causing it to look like this is happening?

paulhbarker commented 8 years ago

I took a look at it today and you're right, it does use the cap-height of the specified font, but the documentation (your blog post) led me to believe that it would actually set the font-family property, when it only uses the font argument to calculate the padding/margins/etc.