search

jakegross808 / pacn-veg-package

all pacn veg code
Creative Commons Zero v1.0 Universal
1 stars 1 forks source link

Adding new table to ReadEIPS function within utils.R #31

Closed jakegross808 closed 1 month ago

jakegross808 commented 2 years ago

I'm trying to add a new table called EIPS_image_pts to ReadEIPS()

I got the new code in the function and I updated the GetColSpec() code.

However, after committing, pushing, and clean and rebuild when I try to run ReadEIPS() it says it Error in ReadEIPS() : could not find function "ReadEIPS"

Is there some rebuild step I am missing?

wright13 commented 2 years ago

Hmm, that's interesting. I feel like I usually get that error when I make a typo in the function name, but it could be something else. I'm available for a screenshare if you want

wright13 commented 2 years ago

Oh nevermind, I just got the same error from something else and realized that it's because ReadEIPS isn't an exported function (meaning that it's not meant to be seen by users - it's just for internal use inside of other package functions). I'd test it by calling LoadPACNVeg, or if you want to call it by itself you can use pacnvegetation:::ReadEIPS() (notice that it's 3 colons for non-exported functions)

jakegross808 commented 2 years ago

ah gotcha. Thanks, that will help to troubleshoot!

jakegross808 commented 2 years ago

Ok the update worked! This option will likely be better for mapping EIPS transects FilterPACNVeg("EIPS_image_pts")

It contains all image points along a transect (every 100 meters in subalpine and every 200 m in wet forest) including start and end, while the old option FilterPACNVeg("Events_extra_xy_EIPS") only contained the starting point and azimuth.

jakegross808 commented 2 years ago

I haven't merged my branch to main branch though.