search

jakeharding / django-jasmine

Package to integrate Jasmine with Django
Other
78 stars 27 forks source link

http=> https on CDN as it shows error in HTTPS deployments #16

Closed tonythomas01 closed 7 years ago

tonythomas01 commented 7 years ago

I am having further errors too on production - something like:

image

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 93.617% when pulling 8f0c1b3423a40677e986bcfdf9fd537554c084ab on tonythomas01:develop into 06137d66b30179de3d4013dd9d697b50ef2c7924 on jakeharding:develop.

jakeharding commented 7 years ago

Easiest and immediate solution is to override the index.html template and use whatever urls you need for your project. I will need to do some testing to be sure using https is not detrimental to non https projects.

Your screenshot says it is refusing to load the https script/stylesheet but the pull request changes the urls to use https. Seems like changing the urls to https caused the error?

tonythomas01 commented 7 years ago

Easiest and immediate solution is to override the index.html template and use whatever urls you need for your project. I will need to do some testing to be sure using https is not detrimental to non https projects.

I think we have to override base.html as that is the one loading in files. I downloaded and served from a local copy, and things work perfect.

tonythomas01 commented 7 years ago

Also, I think we should release in taggged release versions serving local copy.

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 93.617% when pulling 8f0c1b3423a40677e986bcfdf9fd537554c084ab on tonythomas01:develop into 06137d66b30179de3d4013dd9d697b50ef2c7924 on jakeharding:develop.