Displays all stats. - Githubissues

jakeharding commented 7 years ago

Does not render any charts. Chart data is displayed as an array of integers for now. Reverted karma tests back to using chrome because phantomjs doesn't support the Array.fill() feature of ES6. Addresses issues #33, #32, #30, #23, #26, #27, #20.

bparish628 commented 7 years ago

Super long review. Some are syntax things, some are improvements using different angular features.

jakeharding commented 7 years ago

@bparish628 I believe I got everything. I wasn't sure where to put the service so I added a utils folder and hung the service off the main module.

jakeharding commented 7 years ago

@bparish628 I will have another pull request for updating the DFD and the client server diagram. They will be pdf files so I don't anticipate a review being needed. Do you have the feedback we got from milestone 1? If so, could you snap a photo of it and send it to me?

germonprez commented 7 years ago

Your use of dev/master is great.
- The environmental stuff is great and I’m excited to walk-through the install
- Contributing/copyright/licensing is good
- The Milestone document is helpful and presented well
- The DFD is OK.

o Things like Web UI, Python Server, and mysql DB are pretty vague. o Web UI – as a process should be more verb oriented. Something like Receive and Route GH Information. Python Server? What is this doing? Does it need to be broken into more than a single process? o Overall, the naming is not great. Provide better precision.

I do like the start of the C/S Workflow document.
I like the list of metrics and what can/can’t be done with GHTorrent
Finally, the activity level is great. Love seeing the PRs come across on a regular basis.

On Tue, Mar 28, 2017 at 6:41 PM, Jake Harding notifications@github.com wrote:

@bparish628 https://github.com/bparish628 I will have another pull request for updating the DFD and the client server diagram. They will be pdf files so I don't anticipate a review being needed. Do you have the feedback we got from milestone 1? If so, could you snap a photo of it and send it to me?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jakeharding/repo-health/pull/34#issuecomment-289938149, or mute the thread https://github.com/notifications/unsubscribe-auth/AAoDUIUSkBZ1kKqxAjCWbXfMf_WZc9Ppks5rqZqqgaJpZM4Mnotz .

-- Mutual of Omaha Associate Professor Information Systems College of Information Science & Technology University of Nebraska Omaha http://faculty.ist.unomaha.edu/mgermonprez/cv.txt

jakeharding commented 7 years ago

@germonprez Thanks! 😀

germonprez commented 7 years ago

Right on!

On Tue, Mar 28, 2017 at 6:47 PM, Jake Harding notifications@github.com wrote:

@germonprez https://github.com/germonprez Thanks! 😀

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jakeharding/repo-health/pull/34#issuecomment-289939172, or mute the thread https://github.com/notifications/unsubscribe-auth/AAoDUHiltp_64Wa8YkOIDwIDXe0Rs9Gkks5rqZwhgaJpZM4Mnotz .

-- Mutual of Omaha Associate Professor Information Systems College of Information Science & Technology University of Nebraska Omaha http://faculty.ist.unomaha.edu/mgermonprez/cv.txt

jakeharding / repo-health

Displays all stats. #34