Closed jdmcd closed 5 years ago
Erm. Hi. I didn't expect my fork to show up like this.
Some explanation about the changes:
Foundation.
fixes that. You might want to cherry pick that in nevertheless.I think I'd like to get one more version of Shout
out that supports Swift 4.0, so if this PR could be split into two -- one that fixes the symbol crash, and one that updates Package.swift
to use the new system libraries feature -- that would be ideal
Agreed, that sounds like a good plan. I don't have much bandwidth the next week or so as I'll be mostly offline but I can loop back on this after. Thanks, Jake!
Check out #22. The other part is completely optional, and you can salvage the target setup from gotranseo's or my fork later if you want.
Perfect, I’ll close this for now then. Thanks @vzsg!
Fixes #21. Thanks for the help, @vzsg!