jakeheis / Shout

SSH made easy in Swift
MIT License
357 stars 103 forks source link

Fix Glibc errors #22

Closed jdmcd closed 5 years ago

jdmcd commented 5 years ago

Fixes #21. Thanks for the help, @vzsg!

vzsg commented 5 years ago

Erm. Hi. I didn't expect my fork to show up like this.

Some explanation about the changes:

jakeheis commented 5 years ago

I think I'd like to get one more version of Shout out that supports Swift 4.0, so if this PR could be split into two -- one that fixes the symbol crash, and one that updates Package.swift to use the new system libraries feature -- that would be ideal

jdmcd commented 5 years ago

Agreed, that sounds like a good plan. I don't have much bandwidth the next week or so as I'll be mostly offline but I can loop back on this after. Thanks, Jake!

vzsg commented 5 years ago

Check out #22. The other part is completely optional, and you can salvage the target setup from gotranseo's or my fork later if you want.

jdmcd commented 5 years ago

Perfect, I’ll close this for now then. Thanks @vzsg!