jakeheis / Shout

SSH made easy in Swift
MIT License
360 stars 105 forks source link

List of files in directory #24

Closed allright closed 4 years ago

rafiki270 commented 5 years ago

@jakeheis could you please review this? :)

jakeheis commented 5 years ago

After a quick look it looks to me like most of the changes related to the listing of files within a directory are good to go. However, a lot of these changes are to support the new SFTP.download function, and I think a couple design decisions there need to be discussed more. If a new pull request could be opened with just the directory listing functionality, we can touch that up and merge it in. Another pull request could then be opened with this download functionality which requires more discussion

jakeheis commented 4 years ago

Taken care of by #40