search

jakeheis / SwiftCLI

A powerful framework for developing CLIs in Swift
MIT License
861 stars 72 forks source link

Fix strdup optional check #105

Closed TheCoordinator closed 3 years ago

TheCoordinator commented 3 years ago

This fixes the build of SwiftCLI on Xcode 13 RC.

strdup returns an implicitly unwrapped optional which is breaking the build. The change is quite straightforward and it'd be great if we can merge and make a release as soon as possible.

TheCoordinator commented 3 years ago

@jakeheis Any chance we can get this in? Quite a few tools rely on this for their workflows and as of now they are breaking.

jakeheis commented 3 years ago

Thanks for the contribution. Just so I understand correctly, has the signature of strdup changed from returning an implicitly unwrapped optional to an explicit optional, and this is a fix for that signature change?

TheCoordinator commented 3 years ago

@jakeheis Spot on!

jakeheis commented 3 years ago

Perfect then looks good. Thanks for the fix!

jakeheis commented 3 years ago

Tagged as 6.0.3

TheCoordinator commented 3 years ago

Perfect, thanks @jakeheis