jakehilborn / debbit

Automate spending requirements for high interest checking accounts / credit cards
https://jakehilborn.github.io/debbit/
MIT License
264 stars 31 forks source link

Fails to select payment card amazon_gift_card_reload.py #95

Open z80b80 opened 2 years ago

z80b80 commented 2 years ago

Problem, debbit submits all amazon giftcard payments on default payment method. Config file has multiple cards and has not changed in many months. Problem was first noticed in 2022.6.15. I have been running on 2.1.3 since 2021.11. I have since updated gecko and debbit and the problem still exists.

Monitoring Firefox, I observed the software expanding the list of cards but it would not select the correct card based on last 4. The software proceeded to checkout with the default selected payment method. I expected the software to select the radio for the payment card or fail if it could not find the payment card.

I have tried: using a fresh simple config file Turn off 1-Click payments with amazon

Geckodriver V0.31.0 (linux) Fresh debbit 2.1.5 (also tested on 2.1.3)

z80b80 commented 2 years ago

This appears to be working today. I had 22 payment cards including my Prime Card (Default) in my payment types. I removed all but 9 cards, keeping my Prime Card as default and the system is working today.

There are two issues here. 1) Debbit should never process the default payment if it can not find the card specified in the config! This is dangerous to unwarted transactions on the wrong payment types. Expected behavior is the application would fail on selecting a card, close browser, and retry the next card in the list.

2) The issue with why it couldn't select my card may be due to the rendering of the payment card list table. I had over 22 cards saved with amazon. Reducing the number of cards to 9 allowed the system to work properly.

z80b80 commented 2 years ago

I dug into this some more after I added a new card and it wouldn't work. I was running Debbit in a Linux VM with 800x600 resolution and the card was below the fold on the payment selection screen. I adjusted the resolution to 1920x1080 and it will now select the new card.