search

jakehschwartz / finatra-swagger

Swagger Support For Finatra
https://jakehschwartz.github.io/swagger-finatra
Apache License 2.0
28 stars 19 forks source link

API not working with filter #21

Closed enpuliu closed 6 years ago

enpuliu commented 7 years ago

In the hello-sample, code
filter[SampleFilter].getWithDoc("/courses/:courseId/student/:studentId") doesn't work and server responds 404. API cannot register with filter.

kimxogus commented 6 years ago

I'm having the same problem.

jakehschwartz commented 6 years ago

Thanks @enpuliu and @kimxogus , Ill look into this, but it probably won't be until the new year.

andrerigon commented 6 years ago

Same problem here - the route is not registered. For now, I extracted the endpoint to another controller and defined the filter when adding the controller. Thanks for looking at it!

jakehschwartz commented 6 years ago

Hey guys, quick update: my basement flooded this past weekend so I've been dealing with that. I will try to make time for this next weekend.

jakehschwartz commented 6 years ago

This should be fixed by https://github.com/jakehschwartz/finatra-swagger/pull/35 and will be in the 18.6.0 release

kimxogus commented 6 years ago

cool! when will 18.6.0 be released?

jakehschwartz commented 6 years ago

I published it to sonatype today so hopefully it's available tomorrow

On Sun, Jun 17, 2018, 3:18 PM Taehyun Kim notifications@github.com wrote:

cool! when will 18.6.0 be released?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/jakehschwartz/finatra-swagger/issues/21#issuecomment-397900128, or mute the thread https://github.com/notifications/unsubscribe-auth/ACoHZyHhoRtE2VOLpPDQ9urhey_HC1y2ks5t9qtugaJpZM4OfQR5 .

kimxogus commented 6 years ago

Thanks 👍 BTW, can you push latest commits to repo?

jakehschwartz commented 6 years ago

Yeah, once the newest version is available, I'll push

enpuliu commented 6 years ago

It works for me now, thanks. Close the issue.

kimxogus commented 6 years ago

@jakehschwartz New release seems working, can you push? btw, is there any specific reason not to push latest changes before maven release? I made some changes and use in company's server as private module because maven release and git contents are different so I thought this is not maintained.

jakehschwartz commented 6 years ago

I pushed this morning. Sorry I forgot.

I think of the maven release as my deploy to production, so once my code is "in production", that is when it goes to master. If there is some kind of error in the release, because I have that automated, I don't want it to go to master and have people pull something with an error in it.

kimxogus commented 6 years ago

I understand, then can you checkout develop branch to push unstable latest changes? I think it can help you to find issues before you publish in production

jakehschwartz commented 6 years ago

Yes I can. Laziness got the best of my last time.