search

jakejs / jake

JavaScript build tool, similar to Make or Rake. Built to work with Node.js.
http://jakejs.com
Apache License 2.0
1.97k stars 190 forks source link

Fixed regression introduced by b0fcf1c #246

Closed Arnavion closed 10 years ago

Arnavion commented 10 years ago

That commit broke the ability to load both jakefile and jakelibdir. If loader.loadFile(opts.jakefile) returns true, then loader.loadDirectory(opts.jakelibdir) doesn't get called.

Please be more cautious in accepting broken pull requests...

mde commented 10 years ago

Thanks for fixing this. We have a huge deficit of tests in this area. Integration tests are hard to write, but we could do way better. However, having said that, it's also worth noting that this is software developed by the community -- nobody is paid to work on Jake. Over time its stability, both from the API perspective, and with regard to regressions, has actually been excellent. We're going to continue to maintain that same stability. Apologies for the disruption.

mde commented 10 years ago

Pushed to NPM, v0.7.9.

Arnavion commented 10 years ago

Thanks.