jakejs / jake

JavaScript build tool, similar to Make or Rake. Built to work with Node.js.
http://jakejs.com
Apache License 2.0
1.97k stars 190 forks source link

Check also for "jakefile" (lowercase) #253

Closed adius closed 8 years ago

adius commented 10 years ago

I just had this nasty bug where my jakefile was named "jakefile" instead of "Jakefile". I'm developing on a mac so this wasn't a problem as the mac file system is case-insensitive. However, when I wanted to run my tests with travis I always got an error message because jake couldn't find a jakefile as travis tests are running on linux, which is case-sensitive. So I think you should check also check for a lowercase "jakefile"! What do you think?

ben-ng commented 10 years ago

Can you send us a PR for this? As long as it tries for Jakefile first that shouldn't break anyone's existing code.

cedx commented 10 years ago

+1 This issue also applies to Windows file system... and I also prefer lower-cased filenames :smile:

mde commented 10 years ago

PR for this would be great, probably not that hard to implement: https://github.com/jakejs/jake/blob/master/lib/loader.js#L48

welearnednothing commented 8 years ago

Confirmed fixed in 2dc2b59