search

jakejs / jake

JavaScript build tool, similar to Make or Rake. Built to work with Node.js.
http://jakejs.com
Apache License 2.0
1.97k stars 190 forks source link

Use process.nextTick instead of setTimeout #279

Closed SirAnthony closed 9 years ago

SirAnthony commented 9 years ago

setTimeout in node have weird behavior when debugging jake with node-inspector. The time you spent in paused state added to time timer counts until actual emit, so execution of actual code halt for a long time (actually there is node timer code executed). process.nextTick does the same thing here, delaying execution to the next tick, but it have no problems with timers.

mde commented 9 years ago

Merged, thanks!

mde commented 9 years ago

I've invited you to the Jake org. Do please join if you'd like -- use your committer bit for good, not evil. :)

SirAnthony commented 9 years ago

Oh, that's was fast. But I found an issue with nextTick already.

SirAnthony commented 9 years ago

Thanks, jake is good and simple system, I pretty much like it.

mde commented 9 years ago

Let me know if I can help you out with any info on your nextTick issue.

SirAnthony commented 9 years ago

I added new pull request, but travis failed, not sure why, travis is down now. Probably some old version of node there.

mde commented 9 years ago

Probably need to remove the Node v0.8 dependency in there. NPM is not even upgradeable there anymore, so we should probably just remove it from the .travis.yml.