jakejs / jake

JavaScript build tool, similar to Make or Rake. Built to work with Node.js.
http://jakejs.com
Apache License 2.0
1.97k stars 190 forks source link

bash auto completion #287

Closed kedashoe closed 7 years ago

kedashoe commented 9 years ago

An attempt at bash auto completion. Some notes:

Let me know what you guys think!

mde commented 9 years ago

This looks great. A couple of things:

This is pretty fantastic. If you could tweak the code style, and add a basic smoke test, I'd be very excited to merge this PR!

kedashoe commented 9 years ago

Alright PR updated. JS variable style fixed. I added some tests to task_base.js which seemed the best place for them without creating a new test file. Not perfect, better would be to create a shell script that sources bash_complete.sh.. and calls _auto_jake and outputs those results.. which are then checked by the test runner.. or something like that? Maybe could submit a separate PR for that later if I find some more time. Let me know if anything else for now. EDIT: oh and this closes #189 :house_with_garden:

busticated commented 8 years ago

hey there @kedashoe - this looks awesome and is something i've really been wanting myself. anything i can do to help land this? could you possibly rebase it / bring it up to date with current jake master? cc @mde

kedashoe commented 8 years ago

@busticated rebased, ran test suite, looks like everything still passing :fireworks:

busticated commented 8 years ago

@kedashoe nice, thanks! i'll pull it down and try it out :)

boblauer commented 7 years ago

Is there still a possibility of this getting merged?

mde commented 7 years ago

Sorry to take a while to get this merged. Thanks!