Closed kedashoe closed 7 years ago
This looks great. A couple of things:
This is pretty fantastic. If you could tweak the code style, and add a basic smoke test, I'd be very excited to merge this PR!
Alright PR updated. JS variable style fixed. I added some tests to task_base.js
which seemed the best place for them without creating a new test file. Not perfect, better would be to create a shell script that sources bash_complete.sh
.. and calls _auto_jake
and outputs those results.. which are then checked by the test runner.. or something like that? Maybe could submit a separate PR for that later if I find some more time. Let me know if anything else for now. EDIT: oh and this closes #189 :house_with_garden:
hey there @kedashoe - this looks awesome and is something i've really been wanting myself. anything i can do to help land this? could you possibly rebase it / bring it up to date with current jake master? cc @mde
@busticated rebased, ran test suite, looks like everything still passing :fireworks:
@kedashoe nice, thanks! i'll pull it down and try it out :)
Is there still a possibility of this getting merged?
Sorry to take a while to get this merged. Thanks!
An attempt at bash auto completion. Some notes:
internalOpts
function toprogram.js
so we can tell jake in theauto_complete.js
wrapper what we are doingbash_completion.sh
-f path/to/custom-jakefile
, it will start using targets from the custom jakefile for completionsI did not add any tests, however I ran the current test suite and it appears nothing is broken. To test for now, just sourceEDIT: test included in task_base.jsbin/bash_completion.js
and test with an executablejake
(ie if you have it globally installed, or you have another project that uses jake)Let me know what you guys think!