search

jakejs / jake

JavaScript build tool, similar to Make or Rake. Built to work with Node.js.
http://jakejs.com
Apache License 2.0
1.97k stars 190 forks source link

PackageTask.archiveNoBaseDir with tar formats fails #306

Closed welearnednothing closed 8 years ago

welearnednothing commented 8 years ago

This results in an error such as the following: Error: Command failed: tar: ../build-1.0.0.tgz: Can't add archive to itself tar: -x: Cannot stat: No such file or directory tar: ../*: Cannot stat: No such file or directory

The current selector of "." was used because the previous selector, "", was not including hidden files. However, the * expands the files from . and ends up including the parent (..) directory, hence the attempt to exclude it (which works for zip, but is incorrect for tar commands). However, simply using "." as the file selector yields the desired results across compression programs.

mde commented 8 years ago

Thank you!

mde commented 8 years ago

I've added you to the JakeJS GitHub org, to make it easier if you have other fixes and contributions. Thank you very much!

welearnednothing commented 8 years ago

Thanks @mde! I've been digging into JS build tools as of late for work and really, really like what you've done with Jake!