jakejs / jake

JavaScript build tool, similar to Make or Rake. Built to work with Node.js.
http://jakejs.com
Apache License 2.0
1.97k stars 190 forks source link

Test adjustments and improvements. #425

Open Tzrlk opened 1 year ago

Tzrlk commented 1 year ago
Tzrlk commented 1 year ago

I'm aware this set of changes is less surgical than it could be, so if there's anything you'd like me to pull back on, please let me know.

I really wanted to be able to get the tests running properly in my windows environment before I started rewriting more things.

Tzrlk commented 1 year ago

I also note that the travis build specifies node 8, 10, and 12. These changes will definitely not pass those builds. I might look into improving the test runner to execute the jake cli against different nodejs versions, so compatibility with older runtimes can be maintained with transpiling and/or conditional shims.

mde commented 1 year ago

This looks amazing! However, I noticed a bunch of semicolon-less lines in your changeset, and reaalized the following:

I have fixed both of these issues. The conflicts in your PR are doubtless just collisions where eslint --fix added semis, and the one strange added comma in that long regex that you already identified.

I am not super concerned about the older versions of Node. Jake has been around since Node v2, and sometimes things in the codebase take a while to catch up to reality.

Tzrlk commented 1 year ago

I'm super happy I got a positive response to this; thanks a ton. Still have to do something with the build, but it's all clear locally now.

Do you have a preference for Travis? Or would Github actions do just as well? I'll throw some branches together with various changes to make things a bit easier.