search

jakemcc / test-refresh

Refreshes and reruns clojure.tests in your project.
393 stars 28 forks source link

Ability to disable notifications if all tests pass #14

Closed cdorrat closed 10 years ago

cdorrat commented 10 years ago

This change adds a :notify-on-success option that when set to false suppresses growl messages and notifications when all tests pass. I was finding the current behaviour distracting, every time I saved a file I'd get a growl notification. The default behaviour is unchanged

jakemcc commented 10 years ago

Thanks for the pull request. This is a reasonable feature and I could see the usefulness.

I'm not going to merge this in right now because it prevents notifications when there is an error refreshing the environment. I think that notifications should still happen in this situation.

If you have time and feel like updating the pull request to also have notifications when in an "Error" state feel free. Otherwise I'll get around to it either later today or tomorrow and cut a release when that is done.

jakemcc commented 10 years ago

Fixed the issue and merged in. Included in version 0.3.10

cdorrat commented 10 years ago

Thanks, just updated to 0.3.10 and everything is working nicely.

On Sun, Mar 23, 2014 at 7:38 AM, Jake McCrary notifications@github.comwrote:

Fixed the issue and merged in. Included in version 0.3.10

Reply to this email directly or view it on GitHubhttps://github.com/jakemcc/lein-test-refresh/pull/14#issuecomment-38363368 .