search

jakemcc / test-refresh

Refreshes and reruns clojure.tests in your project.
393 stars 28 forks source link

Add more details about the error if the compilation failed #81

Closed minhtuannguyen closed 5 years ago

minhtuannguyen commented 5 years ago

Currently the error message looks like this:

Error refreshing environment: Syntax error compiling at (a/b/c/namespace.clj:80:7).

It's useful to add the error cause why is failed. i.e

Error refreshing environment: Syntax error compiling at (a/b/c/namespace.clj:80:7). java.lang.RuntimeException: Unable to resolve symbol: x in this context

jakemcc commented 5 years ago

i completely agree. I'll try to find some time to look I to this. Have a few other changes queued up right now as well.

Any more details on your environment? Clojure versions etc.

I haven't dug into it but I also recently noticed bad error messages when I used to expect better ones and am wondering if they changed when I upgraded my projects to clojure 1.10

On Fri, Mar 15, 2019, 10:32 Minh Tuan Nguyen notifications@github.com wrote:

Currently the error message looks like this:

Error refreshing environment: Syntax error compiling at (a/b/c/namespace.clj:80:7).

It's useful to add the error cause why is failed. i.e

Error refreshing environment: Syntax error compiling at (a/b/c/namespace.clj:80:7). java.lang.RuntimeException: Unable to resolve symbol: x in this context

You can view, comment on, or merge this pull request online at:

https://github.com/jakemcc/lein-test-refresh/pull/81 Commit Summary

  • add more details about the error if the compilation failed

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jakemcc/lein-test-refresh/pull/81, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHzpthRgE_QCGugkcFLTNpFhY9JZ7acks5vW70XgaJpZM4b2uzc .

jakemcc commented 5 years ago

Ha, didn't notice this was a PR in my email and thought it was just an issue. Should be easy to get this in. Thanks.

On Mon, Mar 18, 2019, 17:26 Jake McCrary jake@jakemccrary.com wrote:

i completely agree. I'll try to find some time to look I to this. Have a few other changes queued up right now as well.

Any more details on your environment? Clojure versions etc.

I haven't dug into it but I also recently noticed bad error messages when I used to expect better ones and am wondering if they changed when I upgraded my projects to clojure 1.10

On Fri, Mar 15, 2019, 10:32 Minh Tuan Nguyen notifications@github.com wrote:

Currently the error message looks like this:

Error refreshing environment: Syntax error compiling at (a/b/c/namespace.clj:80:7).

It's useful to add the error cause why is failed. i.e

Error refreshing environment: Syntax error compiling at (a/b/c/namespace.clj:80:7). java.lang.RuntimeException: Unable to resolve symbol: x in this context

You can view, comment on, or merge this pull request online at:

https://github.com/jakemcc/lein-test-refresh/pull/81 Commit Summary

  • add more details about the error if the compilation failed

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/jakemcc/lein-test-refresh/pull/81, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHzpthRgE_QCGugkcFLTNpFhY9JZ7acks5vW70XgaJpZM4b2uzc .

minhtuannguyen commented 5 years ago

Thank you for your reply. My setup is clojure 1.11 with Leiningen 2.9.1

minhtuannguyen commented 5 years ago

I also noticed that the error message got bad since I upgrade to clojure 1.9

jakemcc commented 5 years ago

Released in version 0.24.0. Thanks for the contribution