Additional dependencies 1

jakeret / hope

HOPE: A Python Just-In-Time compiler for astrophysical computations

GNU General Public License v3.0

382 stars 28 forks source link

Additional dependencies 1 #2

Closed iankronquist closed 9 years ago

iankronquist commented 9 years ago

Fixes Issue #1. Also adds a .gitignore.

iankronquist commented 9 years ago

FYI, I'm not seeing any travis CI builds being kicked off. Travis may not be properly configured.

cosmo-ethz commented 9 years ago

The project is registered on travis CI and the builds are enabled. ATM I don’t really know why changes aren’t starting the builds. I will look into that. Could it be due to the dependency on a C++ compiler? Any clues?

iankronquist commented 9 years ago

@cosmo-ethz updated according to your comments.

cosmo-ethz commented 9 years ago

Splitting up the dependencies makes sense. Apart from one dependency the list seems to be complete (pytest-cov used in the tox.ini). However, defining specific versions could lead to some issues if the user previously installed another version on his machine. Therefore I suggest either skipping the version or defining a minimum version (>=) instead.

iankronquist commented 9 years ago

@cosmo-ethz updated according to your comments.

coveralls commented 9 years ago

Coverage remained the same when pulling fe37b1a84258eac74413903f0778a10ab2036714 on iankronquist:additional-dependencies-1 into e108d9d6e259ab826c2b97546b6ce5395001a8e1 on cosmo-ethz:master.