search

jakesankey / git-history

View previous versions of any file known to git.
https://atom.io/packages/git-history
MIT License
28 stars 10 forks source link

Make it more readable #11

Closed silvenon closed 9 years ago

silvenon commented 9 years ago

I think this is more readable, it's more how GitHub does it. Also, this displays time too. :clock10:

Before:

After:

jakesankey commented 9 years ago

I like it! Can you confirm that this solution will work for other themes as well and still be readable?

silvenon commented 9 years ago

Update. Now 2nd and 3rd line are both the same color. The fact that 1st and 2nd line were both white on focus was annoying, and this solution conforms better to the styleguide anyway. (I updated the screenshot.)

Yes, I can confirm that, because I was using classes that were described in the styleguide for the select list. Let's take a light theme, for example:

If it doesn't look good with a certain theme, it's most probably a bug in that theme.

jakesankey commented 9 years ago

Thanks!