jakesankey / git-history

View previous versions of any file known to git.
https://atom.io/packages/git-history
MIT License
28 stars 10 forks source link

Highlight changes #16

Closed rthijssen closed 9 years ago

rthijssen commented 9 years ago

I'm sure if this has been suggested before but it would be great if the current file could show what has changed since the commit that is shown. This would make code reviews a lot easier ;)

webanck commented 9 years ago

I support this request ! You made multiple good packages in this direction already, please continue to add to the "git colorify the world with my commits and diffs" ;)

jakesankey commented 9 years ago

I have looked into adding this in the future.. A previous release included a rudimentary implementation of diffing, however, I removed it (temporarily?) in favor of other plugins that solely handle diff visualization.

rthijssen commented 9 years ago

So I've looked around for plugins that do this. One of the plugins I found is Atom compare files. But none of them seem to support diffing commits.

I don't know what the best approach is to implement this feature, but I like what you have and adding a similar diffing view to what for example Kaleidoscope has would be pretty amazing.

I'm fully aware of what I'm asking for, and realize this is not a simple feature. But if you have an idea on how to do this I'm more than happy to help you out (with the limited amount of time I have) if necessary.

rthijssen commented 9 years ago

Not sure if useful, but maybe Mergely could make implementing this feature a whole lot easier?

jakesankey commented 9 years ago

I released a new version today that includes an initial implementation of diffing. In the git-history settings, just enable 'Show Diff' if it isn't already enabled. it will show you what has changed in your current version of the file vs. the commit you selected.

rthijssen commented 9 years ago

Awesome, thanks heaps for implementing this so quickly.

webanck commented 9 years ago

Yeah, this is super awesome!

jakesankey commented 9 years ago

Great! Thanks for the feedback. Enjoy! :+1: