Closed nardeas closed 7 years ago
build failed
Locally changing this file fixed the issue for me! Thanks much.
@andreasur could you pls merge and release new version, so that the change benefits us all?
I hope you have time to do it :) Thanks!
Sorry all, I haven't been using Atom lately. I will try to get this published soon.
Jake
Sent from my iPhone
On Mar 2, 2017, at 3:32 AM, Jesper Rønn-Jensen notifications@github.com wrote:
@andreasur could you pls merge and release new version, so that the change benefits us all?
I hope you have time to do it :) Thanks!
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.
Please correct the issue with the failing build and I will happily merge.
@jakesankey could it be an erroneous test?
class GitHistoryView extends SelectListView
initialize: (@file) ->
super()
@show() if file
GitHistoryView.prototype.initialize = function(file1) {
this.file = file1;
GitHistoryView.__super__.initialize.call(this);
if (file) {
return this.show();
}
};
As you may notice, by plugging @file
on the variable argument so it can be attached to the object, requires to use above as @file
otherwise it will render an undefined variable.
Is there any chance you can help OP with it? I think your plugin is a great work but unfortunately it isn't working because of a @
.
Sorry for the delay. I released this in a patch today. Thanks for the contribution!
This fixed issue #39 for me.