jakeswenson / BitBetter

Modify bit warden to provide my own licensing for self hosting
500 stars 112 forks source link

Update bitwarden.sh path #127

Closed reliacon-dev closed 2 years ago

reliacon-dev commented 2 years ago

Bitwarden.sh script was moved yesterday and caused an error during BitBetter's build

Output before change:

Building BitBetter for BitWarden version 
+ dotnet add package Newtonsoft.Json --version 12.0.3
...
Sending build context to Docker daemon  2.993MB
Step 1/6 : ARG BITWARDEN_TAG
Step 2/6 : FROM ${BITWARDEN_TAG}
invalid reference format
Sending build context to Docker daemon  2.993MB
Step 1/6 : ARG BITWARDEN_TAG
Step 2/6 : FROM ${BITWARDEN_TAG}
invalid reference format
Error response from daemon: No such image: bitbetter/api:latest
Error response from daemon: No such image: bitbetter/identity:latest
Error parsing reference: "bitbetter/api:" is not a valid repository/tag: invalid reference format
Error parsing reference: "bitbetter/identity:" is not a valid repository/tag: invalid reference format

Output after change:

Building BitBetter for BitWarden version 1.46.2
+ dotnet add package Newtonsoft.Json --version 12.0.3
...
Successfully built 81cb395e875b
Successfully tagged bitbetter/api:latest
...
Successfully built ec2a0d378578
Successfully tagged bitbetter/identity:latest
reliacon-dev commented 2 years ago

Not sure which branch you want PRs opened against

captainhook commented 2 years ago

Not sure which branch you want PRs opened against

Master is fine, although we really should be using a test branch 👀

Requesting review from our fellow stars

reliacon-dev commented 2 years ago

Similar change made to update script