jakeswenson / BitBetter

Modify bit warden to provide my own licensing for self hosting
510 stars 115 forks source link

licenseGen.sh in unified branch isn't working (.NET?) #188

Closed Jonathan-Kortleven closed 8 months ago

Jonathan-Kortleven commented 8 months ago

To reproduce: just pull the unified branch and try to generate a license. I think the unified branch is still behind on the .NET 8.0 fixes.

./licenseGen.sh You must install or update .NET to run this application.

App: /app/licenseGen.dll Architecture: x64 Framework: 'Microsoft.NETCore.App', version '8.0.0' (x64) .NET location: /usr/share/dotnet/

The following frameworks were found: 6.0.27 at [/usr/share/dotnet/shared/Microsoft.NETCore.App]

Learn about framework resolution: https://aka.ms/dotnet/app-launch-failed

To install missing framework, download: https://aka.ms/dotnet-core-applaunch?framework=Microsoft.NETCore.App&framework_version=8.0.0&arch=x64&rid=debian.11-x64

captainhook commented 8 months ago

Please take a look at #180, @GieltjE something may have been missed.

TheSp1der commented 8 months ago

~I can confirm this issue.~ I build my images via Jenkins and this is a new issue that just cropped up.

dotnet restore Determining projects to restore... /usr/share/dotnet/sdk/6.0.419/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.TargetFrameworkInference.targets(144,5): error NETSDK1045: The current .NET SDK does not support targeting .NET 8.0. Either target .NET 6.0 or lower, or use a version of the .NET SDK that supports .NET 8.0. [/home/jenkins/agent/workspace/build-bitbetter/bitbetter/src/bitBetter/bitBetter.csproj]

I see that the latest commit message is "Update to .NET 8.0 to fix building with bitwarden v2024.2.2 (#187)" but my pipeline is still experiencing an issue, double checking it now.

Edit: Found my issue, it was unrelated and I have confirmed that the latest commit seems to have resolved the .NET version problem.

GieltjE commented 8 months ago

Made a new pull request, created my patch sets to quickly and missed half of it......

Jonathan-Kortleven commented 8 months ago

Thanks guys, tested & works like a charm!