jakeswenson / BitBetter

Modify bit warden to provide my own licensing for self hosting
506 stars 112 forks source link

Default value for ARG ${BITWARDEN_TAG} results in empty or invalid base image name #209

Open Midorina opened 1 month ago

Midorina commented 1 month ago

Hello,

I have Bitwarden 2024.9.1 and the latest version of BitBetter. When I try to execute ./build.sh, I get the warning in the title. Full log:

root@bitwarden:~/BitBetter# ./build.sh
Building BitBetter for BitWarden version 2024.9.1
+ dotnet restore
  Determining projects to restore...
  Restored /bitBetter/bitBetter.csproj (in 882 ms).
+ dotnet publish
  Determining projects to restore...
  All projects are up-to-date for restore.
  bitBetter -> /bitBetter/bin/Release/net8.0/bitBetter.dll
  bitBetter -> /bitBetter/bin/Release/net8.0/publish/
[+] Building 1.1s (9/9) FINISHED                                                                                                                                                                                                              docker:default
 => [internal] load build definition from Dockerfile                                                                                                                                                                                                    0.0s
 => => transferring dockerfile: 370B                                                                                                                                                                                                                    0.0s
 => WARN: InvalidDefaultArgInFrom: Default value for ARG ${BITWARDEN_TAG} results in empty or invalid base image name (line 2)                                                                                                                          0.0s
 => [internal] load metadata for docker.io/bitwarden/api:2024.9.1                                                                                                                                                                                       0.0s
 => [internal] load .dockerignore                                                                                                                                                                                                                       0.0s
 => => transferring context: 2B                                                                                                                                                                                                                         0.0s
 => CACHED [1/4] FROM docker.io/bitwarden/api:2024.9.1                                                                                                                                                                                                  0.0s
 => [internal] load build context                                                                                                                                                                                                                       0.0s
 => => transferring context: 2.18kB                                                                                                                                                                                                                     0.0s
 => [2/4] COPY bin/Release/net8.0/publish/* /bitBetter/                                                                                                                                                                                                 0.0s
 => [3/4] COPY ./.keys/cert.cert /newLicensing.cer                                                                                                                                                                                                      0.0s
 => [4/4] RUN set -e; set -x;     dotnet /bitBetter/bitBetter.dll &&     mv /app/Core.dll /app/Core.orig.dll &&     mv /app/modified.dll /app/Core.dll &&     rm -rf /bitBetter && rm -rf /newLicensing.cer                                             0.8s
 => exporting to image                                                                                                                                                                                                                                  0.1s
 => => exporting layers                                                                                                                                                                                                                                 0.1s
 => => writing image sha256:5991eee4251b498fcbc10ec4430e8c9c1d73469216f6418d0fabb52b5ff809f4                                                                                                                                                            0.0s
 => => naming to docker.io/bitbetter/api                                                                                                                                                                                                                0.0s

 1 warning found (use docker --debug to expand):
 - InvalidDefaultArgInFrom: Default value for ARG ${BITWARDEN_TAG} results in empty or invalid base image name (line 2)
[+] Building 1.1s (9/9) FINISHED                                                                                                                                                                                                              docker:default
 => [internal] load build definition from Dockerfile                                                                                                                                                                                                    0.0s
 => => transferring dockerfile: 370B                                                                                                                                                                                                                    0.0s
 => WARN: InvalidDefaultArgInFrom: Default value for ARG ${BITWARDEN_TAG} results in empty or invalid base image name (line 2)                                                                                                                          0.0s
 => [internal] load metadata for docker.io/bitwarden/identity:2024.9.1                                                                                                                                                                                  0.0s
 => [internal] load .dockerignore                                                                                                                                                                                                                       0.0s
 => => transferring context: 2B                                                                                                                                                                                                                         0.0s
 => CACHED [1/4] FROM docker.io/bitwarden/identity:2024.9.1                                                                                                                                                                                             0.0s
 => [internal] load build context                                                                                                                                                                                                                       0.0s
 => => transferring context: 780B                                                                                                                                                                                                                       0.0s
 => [2/4] COPY bin/Release/net8.0/publish/* /bitBetter/                                                                                                                                                                                                 0.0s
 => [3/4] COPY ./.keys/cert.cert /newLicensing.cer                                                                                                                                                                                                      0.0s
 => [4/4] RUN set -e; set -x;     dotnet /bitBetter/bitBetter.dll &&     mv /app/Core.dll /app/Core.orig.dll &&     mv /app/modified.dll /app/Core.dll &&     rm -rf /bitBetter && rm -rf /newLicensing.cer                                             0.8s
 => exporting to image                                                                                                                                                                                                                                  0.1s
 => => exporting layers                                                                                                                                                                                                                                 0.1s
 => => writing image sha256:3832fbbf0351a6c7b10981de5a35205caffa975be63451f35941771444831f08                                                                                                                                                            0.0s
 => => naming to docker.io/bitbetter/identity                                                                                                                                                                                                           0.0s

 1 warning found (use docker --debug to expand):
 - InvalidDefaultArgInFrom: Default value for ARG ${BITWARDEN_TAG} results in empty or invalid base image name (line 2)

Is this a real problem, or can I just ignore it?

GieltjE commented 16 hours ago

Does this still occur on the latest version?