search

jakesylvestre / flexicontent

Automatically exported from code.google.com/p/flexicontent
0 stars 0 forks source link

same errors if Joomfish is not installed #242

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
FC 2.0 r939

I bealive, You are know it, but.. jast to not forget... in file 
"administrator\components\com_flexicontent\views\items\tmpl\default.php" 
commented all "if (FLEXI_FISH)" statement.
If Joomfish is not installed, then there are same errors. (for example, Flag 
img has empty src)

Original issue reported on code.google.com by aaza...@gmail.com on 23 Oct 2011 at 7:43

GoogleCodeExporter commented 8 years ago 
i never meant for flag to appear, since Joomfish not installed, besides missing 
flags you get some PHP error or warning ?

Original comment by ggp...@gmail.com on 23 Oct 2011 at 8:23

GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
[deleted comment]
GoogleCodeExporter commented 8 years ago 
No,there is no PHP errors or warning. Just not correct HTML-tags in the 
backend. And all is well, if uncomment all of the "if (FLEXI_FISH)" / "endif".

Original comment by aaza...@gmail.com on 24 Oct 2011 at 4:59

GoogleCodeExporter commented 8 years ago 
About the images of flags , i deliberately left it there like this,
but now that i think of it is better to have just the label there if not flags 
present instead of invalid image html tag, ok about this will change plus on 
some browser you get a broken image.

Other broken html exists (besides the images) ?

Original comment by ggp...@gmail.com on 24 Oct 2011 at 6:32

GoogleCodeExporter commented 8 years ago 
This is a good idea to do a literal labels for language.

There are no other broken html present.

Original comment by aaza...@gmail.com on 24 Oct 2011 at 7:18

GoogleCodeExporter commented 8 years ago 
Fixed in r969 by using the joomla installed flags

Original comment by ggp...@gmail.com on 23 Nov 2011 at 4:36