[PATCH] Tolerate bad ponder moves (UCI)

[GoogleCodeExporter]

I'm not sure why I didn't run into this before, but an engine will hang if it 
sends a "malformed" ponder move (one that doesn't even look like algebraic 
notation). An engine might do something that weird if it plays a mate or draw. 
The move should be ignored instead.
Patch is against hg. (Line #s are off because I made my patches for issue 142 
first.)

Original issue reported on code.google.com by Uncombed...@gmail.com on 6 Mar 2011 at 5:05

[GoogleCodeExporter]

Yes. I've seen this before as well.
If you'll attach your patch, we can have a look ;)

Original comment by lobais on 7 Mar 2011 at 12:25

[GoogleCodeExporter]

D'oh!!

Well, while I'm at it, maybe I should drop my other small changes here instead 
of spamming the tracker with a bunch of new issues. So far:

pychess_uci_ponder.patch: Fixes #648
pychess_glade_fix_page_size.patch: Fixes warnings about a deprecated non-zero 
page size in a SpinButton's adjustment. (The page size has no effect anyway.)
pychess_show_cords.patch: Changes "Show cords" to "Show coordinates" in the 
GUI. (The "cords" abbreviation is very rare. The string even confused the 
Spanish translator, who translated "Show ropes".)
pychess_showMessage.patch: Makes showMessage work -- under at least Ubuntu 
10.10 it's broken. This one is a hack, in that it still relies on the 
child-widget layout of a GTK MessageDialog.

Original comment by Uncombed...@gmail.com on 7 Mar 2011 at 12:50

Attachments:

• pychess_uci_ponder.patch
• pychess_glade_fix_page_size.patch
• pychess_show_cords.patch
• pychess_showMessage.patch

[GoogleCodeExporter]

:) While I appreciate the thoughtfulness of not spamming the tracker, I believe 
sorting out issues is just what it is meant for.

The cords patch can't really be merged now, since we are string frozen, but it 
is an interesting discussion, whether there is a better word in chess for 
cords. "Coordinates" seams a bit geographical..

I've merged the three other patches.
Thanks.

Original comment by lobais on 7 Mar 2011 at 2:29

• Changed state: Fixed

[GoogleCodeExporter]

Actually, the showMessage fix seams to already have been applied on trunk

Original comment by lobais on 7 Mar 2011 at 2:57

[GoogleCodeExporter]

String freeze is a valid concern. I'll try to find a native Spanish speaker to 
confirm my suspicion about "mostrar cuerdas" -- It's still OK to fix .po files, 
right?
As for the best English string: I like coordinates, but an alternative is 
"label files and ranks" (or say rows/columns, or "label edge of chessboard").

Original comment by Uncombed...@gmail.com on 7 Mar 2011 at 8:58

[GoogleCodeExporter]

Yup, going on Rosetta and fixing the translations is no problem.

Original comment by lobais on 7 Mar 2011 at 9:39