jakesylvestre / pychess

Automatically exported from code.google.com/p/pychess
GNU General Public License v3.0
1 stars 7 forks source link

[PATCH] strateval: Only report a pin if it's new. #654

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
A PGN is worth a thousand words. If you load the attached "game" and look at 
the comments panel, it says "White pins an enemy bishop to the king at a8". 
This looks silly since the pin was already there.

The example is artificial, but I noticed this in a real game. I've made it say 
nothing in this situation. I think that's the best thing to do: if strateval 
gets more attention, it will learn to say when a move breaks a pin.

Original issue reported on code.google.com by Uncombed...@gmail.com on 12 Mar 2011 at 10:01

Attachments:

GoogleCodeExporter commented 9 years ago
That is indeed stupid.
Another great patch Justin. I've given you commit access, so you can fix errors 
more easily.

Original comment by lobais on 12 Mar 2011 at 10:33

GoogleCodeExporter commented 9 years ago
Applied. Thanks!

Original comment by Uncombed...@gmail.com on 13 Mar 2011 at 1:00